Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): add vibration option to notifications channel #2787

Merged
merged 2 commits into from
May 7, 2020
Merged

feat(android): add vibration option to notifications channel #2787

merged 2 commits into from
May 7, 2020

Conversation

aren1989
Copy link
Contributor

Please add notification vibration option on channel manager, it's very useful

@aren1989
Add notification vibrate option
d891708 
please add notification vibration option on channel manager, it's very useful
@aren1989 aren1989 changed the title Add notification vibrate option Add push notification vibrate option Apr 17, 2020
@jcesarmobile jcesarmobile self-requested a review May 7, 2020 13:25
jcesarmobile
jcesarmobile approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR!

I've renamed to "vibration" and added the needed type, will merge once tests finish

@jcesarmobile jcesarmobile changed the title Add push notification vibrate option feat(android): add vibration option to notifications channel May 7, 2020
@jcesarmobile jcesarmobile merged commit 2f6f0ba into ionic-team:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aren1989 @jcesarmobile